[*] Code review

core/CMakeLists.txt

@@ -8,5 +8,3 @@ add_library(${PROJECT_NAME} STATIC ${CORE_SRCS} ${CORE_HEADERS})
 
 #This paths will be used by project-dependent project libraries
 target_include_directories(dap_core INTERFACE .)
-
-set(${PROJECT_NAME}_INCLUDE_DIRS ${PROJECT_SOURCE_DIR} CACHE INTERNAL "${PROJECT_NAME}: Include Directories" FORCE)

crypto/CMakeLists.txt

@@ -50,5 +50,3 @@ add_library(${PROJECT_NAME} STATIC ${CRYPTO_SRCS}
 target_include_directories(dap_crypto INTERFACE .)
 
 target_link_libraries(dap_crypto dap_core)
-
-set(${PROJECT_NAME}_INCLUDE_DIRS ${PROJECT_SOURCE_DIR} CACHE INTERNAL "${PROJECT_NAME}: Include Directories" FORCE)

crypto/dap_enc.c

@@ -117,7 +117,7 @@ size_t dap_enc_decode(struct dap_enc_key * key,const void * buf, const size_t bu
 
     if(key->dec){
         size_t ret=key->dec(key,proc_buf_const,proc_buf_size,buf_out);
-        if(data_type_in==DAP_ENC_DATA_TYPE_B64 || DAP_ENC_DATA_TYPE_B64_URLSAFE)
+        if(data_type_in==DAP_ENC_DATA_TYPE_B64 || data_type_in == DAP_ENC_DATA_TYPE_B64_URLSAFE)
         	if (proc_buf)
         		free(proc_buf);
         return ret;

crypto/dap_enc.h

@@ -29,8 +29,8 @@
 extern "C" {
 #endif
 
-int dap_enc_init();
-void dap_enc_deinit();
+int dap_enc_init(void);
+void dap_enc_deinit(void);
 
 size_t dap_enc_code(struct dap_enc_key * key, const void * buf, const size_t buf_size, void * buf_out,
                     dap_enc_data_type_t data_type_out);

crypto/dap_enc_aes.h

@@ -16,7 +16,6 @@ void dap_enc_aes_key_new_generate(struct dap_enc_key * a_key,size_t a_size);
 void dap_enc_aes_key_new_from_data(struct dap_enc_key * a_key, const void * a_in, size_t a_in_size);
 void dap_enc_aes_key_new_from_str(struct dap_enc_key * a_key, const char * a_in);
 void dap_enc_aes_key_delete(struct dap_enc_key *a_key);
-int test_key_aes();
 
 size_t dap_enc_aes_decode(struct dap_enc_key* a_key, const void * a_in, size_t a_in_size,void * a_out);
 size_t dap_enc_aes_encode(struct dap_enc_key* a_key, const void * a_in, size_t a_in_size,void * a_out);

crypto/dap_enc_key.h

@@ -121,8 +121,8 @@ typedef struct dap_enc_key{
     void * _inheritor;
 } dap_enc_key_t;
 
-int dap_enc_key_init();
-void dap_enc_key_deinit();
+int dap_enc_key_init(void);
+void dap_enc_key_deinit(void);
 
 dap_enc_key_t *dap_enc_key_new(dap_enc_key_type_t a_key_type);
 

crypto/dap_enc_sidh16.c

@@ -23,13 +23,6 @@ static int isCompressed(void *_inheritor) {
     return 0;
 }
 
-void test(){
- 
-}
-
-
-
-
 extern bool dap_sidh16_CurveIsogenyStruct_isnull(PCurveIsogenyStruct pCurveIsogeny);
 
 void dap_enc_sidh16_key_new_generate(struct dap_enc_key *a_key, size_t a_size) {

crypto/dap_enc_sidh16.h

@@ -13,8 +13,6 @@
 #include"liboqs/kex_sidh_cln16/SIDH.h"
 #include "liboqs/kex/kex.h"
 
-
-
 struct dap_enc_key;
 
 extern bool dap_sidh16_CurveIsogenyStruct_isnull(PCurveIsogenyStruct pCurveIsogeny);

libdap.pri

 include (core/core.pri)
 include (crypto/crypto.pri)
 
-
 INCLUDEPATH += $$PWD