From 35ab47c8ec6a8b152b00a27c53abef0a24725897 Mon Sep 17 00:00:00 2001
From: "roman.khlopkov" <roman.khlopkov@demlabs.net>
Date: Thu, 18 Jan 2024 18:30:40 +0300
Subject: [PATCH] [*] tx_history evil bug with UB fixed
---
modules/net/dap_chain_node_cli_cmd_tx.c | 2 +-
modules/type/blocks/dap_chain_cs_blocks.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/modules/net/dap_chain_node_cli_cmd_tx.c b/modules/net/dap_chain_node_cli_cmd_tx.c
index 25aa588625..f9160c1128 100644
--- a/modules/net/dap_chain_node_cli_cmd_tx.c
+++ b/modules/net/dap_chain_node_cli_cmd_tx.c
@@ -323,7 +323,6 @@ json_object* dap_db_history_addr(dap_chain_addr_t *a_addr, dap_chain_t *a_chain,
bool l_is_need_correction = false;
uint256_t l_corr_value = {}, l_unstake_value = {};
json_object *l_corr_object = NULL;
- bool l_is_unstake = false;
// load transactions
dap_chain_datum_iter_t *l_datum_iter = a_chain->callback_datum_iter_create(a_chain);
@@ -335,6 +334,7 @@ json_object* dap_db_history_addr(dap_chain_addr_t *a_addr, dap_chain_t *a_chain,
// go to next datum
continue;
// it's a transaction
+ bool l_is_unstake = false;
dap_chain_datum_tx_t *l_tx = (dap_chain_datum_tx_t *)l_datum->data;
dap_list_t *l_list_in_items = dap_chain_datum_tx_items_get(l_tx, TX_ITEM_TYPE_IN_ALL, NULL);
if (!l_list_in_items) // a bad tx
diff --git a/modules/type/blocks/dap_chain_cs_blocks.c b/modules/type/blocks/dap_chain_cs_blocks.c
index 4e3030ea49..80aaa37728 100644
--- a/modules/type/blocks/dap_chain_cs_blocks.c
+++ b/modules/type/blocks/dap_chain_cs_blocks.c
@@ -202,7 +202,7 @@ int dap_chain_cs_blocks_init()
" -cert <priv_cert_name> -addr <addr> -hashes <hashes_list> -fee <value>\n"
"\t\t Take delegated part of reward\n\n"
- "Rewards and comission autocollect status:\n"
+ "Rewards and fees autocollect status:\n"
"block -net <net_name> -chain <chain_name> autocollect status\n"
"\t\t Show rewards and fees automatic collecting status (enabled or not)."
" Show prepared blocks for collecting rewards and fees if status is enabled\n"
--
GitLab